Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/babel-preset into bazel #97271

Merged
merged 7 commits into from
Apr 19, 2021
Merged

chore(NA): moving @kbn/babel-preset into bazel #97271

merged 7 commits into from
Apr 19, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 15, 2021

One step forward on #69706

That PR moves the @kbn/babel-preset into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 15, 2021
@mistic mistic requested a review from jbudz April 15, 2021 15:18
@mistic mistic mentioned this pull request Apr 15, 2021
Closed
23 tasks
@mistic mistic marked this pull request as ready for review April 15, 2021 16:24
@mistic mistic requested review from a team as code owners April 15, 2021 16:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows. LGTM

mattkime
mattkime approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App Services changes lgtm

@mistic mistic enabled auto-merge (squash) April 15, 2021 19:56
@mistic

This comment has been minimized.

Sign in to view
@mistic

This comment has been minimized.

Sign in to view
@mistic

This comment has been minimized.

Sign in to view
@mistic

This comment has been minimized.

Sign in to view
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI changes LGTM! 👍

@mistic mistic merged commit b6fd288 into elastic:master Apr 19, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 19, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/babel-preset into bazel (elastic#97271)
4bc31a1 
* chore(NA): moving @kbn/babel-preset into bazel

* chore(NA): remove unused deps from xpack package.json
@kibanamachine kibanamachine mentioned this pull request Apr 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 19, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/babel-preset into bazel (#97271) (#97436)
a5f590d 
* chore(NA): moving @kbn/babel-preset into bazel

* chore(NA): remove unused deps from xpack package.json

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

@Bamieh Bamieh Bamieh approved these changes

@jbudz jbudz jbudz approved these changes

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mistic @elasticmachine @kibanamachine @mattkime @jbudz @Bamieh @yuliacech