[Fleet] Show lock icon + tooltip next to hosted agent policy names #97377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
jfsiii
added
auto-backport
23 tasks
jfsiii
changed the title
|
@elasticmachine merge upstream |
ruflin
approved these changes
Apr 18, 2021
There was a problem hiding this comment.
LGTM. I checked the policy list and integrations overview page locally and icon + tooltip show up as expected. I tested it with the fleet-server package but didn't have a fleet-server enrolled currently, that is why I didn't check the other two screens. But can't see a reason why it would not work.
| @@ -8323,7 +8323,6 @@ | |||
| "xpack.fleet.agentList.policyColumnTitle": "代理策略", | |||
| "xpack.fleet.agentList.policyFilterText": "代理策略", | |||
| "xpack.fleet.agentList.reassignActionText": "分配到新策略", | |||
| "xpack.fleet.agentList.revisionNumber": "修订版 {revNumber}", | |||
There was a problem hiding this comment.
Not fully sure how this works. But it seems the revisionNumber is still available in the new code?
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jfsiii |
|
Thanks for the 👀 and 🚀 , @ruflin. I'm going to merge this and we can open bug tickets if we find something missing/wrong |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 19, 2021
…ic#97377) ## Summary From design ticket elastic/observability-design#32 > any ... place we display a link to the hosted agent policy, show an icon with hover tooltip: This PR closes 1B + 1C from elastic#91906 & two other places which followed the same pattern. Factored out some repeated code at each call site into a `<AgentPolicySummaryLine />` component <details><summary>Screenshots</summary> <h3>Agent Policy List View</h3> <img width="1103" alt="Screen Shot 2021-04-16 at 1 01 55 PM" src="https://user-images.githubusercontent.com/57655/115059112-18a99180-9eb4-11eb-9035-36a8e9db1f9d.png"> <h3>Agent List View</h3> <img width="1185" alt="Screen Shot 2021-04-16 at 12 38 40 PM" src="https://user-images.githubusercontent.com/57655/115058885-bea8cc00-9eb3-11eb-8529-6f185fcac7d2.png"> <h3>Packaged Policy List View</h3> <img width="1251" alt="Screen Shot 2021-04-16 at 10 23 49 AM" src="https://user-images.githubusercontent.com/57655/115058880-be103580-9eb3-11eb-8060-c501663af556.png"> <h3>Agent Policy Detail View</h3> <img width="1145" alt="Screen Shot 2021-04-16 at 12 21 42 PM" src="https://user-images.githubusercontent.com/57655/115058883-bea8cc00-9eb3-11eb-9970-462ff4600fa4.png"> </details> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 19, 2021
… (#97441) ## Summary From design ticket elastic/observability-design#32 > any ... place we display a link to the hosted agent policy, show an icon with hover tooltip: This PR closes 1B + 1C from #91906 & two other places which followed the same pattern. Factored out some repeated code at each call site into a `<AgentPolicySummaryLine />` component <details><summary>Screenshots</summary> <h3>Agent Policy List View</h3> <img width="1103" alt="Screen Shot 2021-04-16 at 1 01 55 PM" src="https://user-images.githubusercontent.com/57655/115059112-18a99180-9eb4-11eb-9035-36a8e9db1f9d.png"> <h3>Agent List View</h3> <img width="1185" alt="Screen Shot 2021-04-16 at 12 38 40 PM" src="https://user-images.githubusercontent.com/57655/115058885-bea8cc00-9eb3-11eb-8529-6f185fcac7d2.png"> <h3>Packaged Policy List View</h3> <img width="1251" alt="Screen Shot 2021-04-16 at 10 23 49 AM" src="https://user-images.githubusercontent.com/57655/115058880-be103580-9eb3-11eb-8060-c501663af556.png"> <h3>Agent Policy Detail View</h3> <img width="1145" alt="Screen Shot 2021-04-16 at 12 21 42 PM" src="https://user-images.githubusercontent.com/57655/115058883-bea8cc00-9eb3-11eb-9970-462ff4600fa4.png"> </details> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: John Schulz <john.schulz@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From design ticket https://github.com/elastic/observability-design/issues/32
This PR closes 1B + 1C from #91906 & two other places which followed the same pattern.
Factored out some repeated code at each call site into a
<AgentPolicySummaryLine />componentScreenshots
Agent Policy List View
Agent List View
Packaged Policy List View
Agent Policy Detail View
Checklist
Delete any items that are not applicable to this PR.