-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump elastic-apm-node from v3.10.0 to v3.14.0 #97509
Conversation
Changelog: https://www.elastic.co/guide/en/apm/agent/nodejs/current/release-notes-3.x.html Notably: - Adds apm.addMetadataFilter(fn) that can be used for PII filtering - Improves communication with APM server to not be pathological if APM server is down for extended period of time and load is high. - Fixes bugs in data for the Dependencies and Service Map in the APM app. - The APM agent now collects cloud metadata.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @trentm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds apm.addMetadataFilter(fn) that can be used for PII filtering
According to https://www.elastic.co/guide/en/apm/server/current/metadata-api.html#metadata-schema
Metadata includes user
and account
data from now on. Are they always collected? If so, the Kibana Core team has to address it in a follow-up PR.
Pinging @elastic/kibana-core (Team:Core) |
@kobelb Do you think we could consider backporting this to the 7.13 branch as a bug fix? It addresses some performance issues that we'd like to see fixed for rolling this instrumentation out more widely. |
If it's a safe bugfix, backport away :) |
💔 Backport failed
To backport manually run: |
Changelog: https://www.elastic.co/guide/en/apm/agent/nodejs/current/release-notes-3.x.html Notably: - Adds apm.addMetadataFilter(fn) that can be used for PII filtering - Improves communication with APM server to not be pathological if APM server is down for extended period of time and load is high. - Fixes bugs in data for the Dependencies and Service Map in the APM app. - The APM agent now collects cloud metadata. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # yarn.lock
Changelog: https://www.elastic.co/guide/en/apm/agent/nodejs/current/release-notes-3.x.html Notably: - Adds apm.addMetadataFilter(fn) that can be used for PII filtering - Improves communication with APM server to not be pathological if APM server is down for extended period of time and load is high. - Fixes bugs in data for the Dependencies and Service Map in the APM app. - The APM agent now collects cloud metadata. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # yarn.lock
Changelog: https://www.elastic.co/guide/en/apm/agent/nodejs/current/release-notes-3.x.html Notably: - Adds apm.addMetadataFilter(fn) that can be used for PII filtering - Improves communication with APM server to not be pathological if APM server is down for extended period of time and load is high. - Fixes bugs in data for the Dependencies and Service Map in the APM app. - The APM agent now collects cloud metadata. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # yarn.lock Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Currently the Node.js APM agent:
This version of the agent added So, yes, there should be a PR to filter:
|
Summary
Bumps the version of the elastic-apm-node dep used for self-APM of Kibana.
Changelog: https://www.elastic.co/guide/en/apm/agent/nodejs/current/release-notes-3.x.html
Notably:
server is down for extended period of time and load is high.
app.
For maintainers
/cc @joshdover @tylersmalley This adds the feature requested in elastic/apm-agent-nodejs#1916 so that metadata could now be filtered for PII there. I don't know if there is any urgency there (e.g. to try to get it in before 7.13 FF).