Fix flaky SO import tests #97586
Merged
Fix flaky SO import tests #97586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
commented
Apr 20, 2021
Comment on lines
-338
to
+337
| await PageObjects.common.clickConfirmOnModal(false); | ||
| await PageObjects.common.clickConfirmOnModal(true); |
There was a problem hiding this comment.
This is what was causing the flakiness.
When adding the tests in FTR tests in #76482, I had to add a manual delay between the first and second modal because the second one is appearing directly, so we can't rely on the ensureHidden option of clickConfirmOnModal. However I forgot to properly await the modal to close after the second click.
|
Flaky test runner - 150 executions - success: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1473/ |
This reverts commit ede007ec
pgayvallet
added
release_note:fix
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
This reverts commit ede007ec
rudolf
approved these changes
Apr 20, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Apr 20, 2021
* Fix flaky SO import tests * [will be reverted] remove all tests from CI group 8 * Revert "[will be reverted] remove all tests from CI group 8" This reverts commit ede007ec * Revert "[will be reverted] remove all tests from CI group 8" This reverts commit ede007ec
pgayvallet
added a commit
that referenced
this pull request
Apr 20, 2021
* Fix flaky SO import tests * [will be reverted] remove all tests from CI group 8 * Revert "[will be reverted] remove all tests from CI group 8" This reverts commit ede007ec * Revert "[will be reverted] remove all tests from CI group 8" This reverts commit ede007ec
madirey
pushed a commit
to madirey/kibana
that referenced
this pull request
May 11, 2021
* Fix flaky SO import tests * [will be reverted] remove all tests from CI group 8 * Revert "[will be reverted] remove all tests from CI group 8" This reverts commit ede007ec * Revert "[will be reverted] remove all tests from CI group 8" This reverts commit ede007ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #95660
Fix #95706