Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[License Management] Migrate to new ES client #97795

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[License Management] Migrate to new ES client #97795

merged 2 commits into from
Apr 23, 2021

Conversation

jloleysens
Copy link
Contributor

Summary

See #73973

How to test

  1. Start Kibana and Elastic on basic license
  2. Navigate to the license management plugin
  3. Start a trial license
  4. End your trial license
  5. Upload a license (internal company resource)

@jloleysens jloleysens added Feature:License v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Apr 21, 2021
@jloleysens jloleysens requested a review from sebelga April 21, 2021 10:22
@jloleysens jloleysens requested a review from a team as a code owner April 21, 2021 10:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga
sebelga approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jloleysens ! Tested locally and works as expected 👍

@alisonelizabeth
Copy link
Contributor

Just passing through 😄 - I could not find any API integration tests for license management. It might be nice to add some either as part of this PR or open an issue to follow up.

@jloleysens
Copy link
Contributor Author

@alisonelizabeth great point! I'll open up an issue for that.

@jloleysens jloleysens merged commit 00c62af into elastic:master Apr 23, 2021
@jloleysens jloleysens deleted the license-management/migrate-legacy-es-client branch April 23, 2021 15:14
@jloleysens jloleysens mentioned this pull request Apr 23, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 23, 2021
@jloleysens @kibanamachine
initial migration (elastic#97795)
a7663cb 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Apr 23, 2021
@jloleysens @kibanamachine
initial migration (#97795) (#98155)
f750704 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Apr 23, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jloleysens @elasticmachine @kibanamachine @alisonelizabeth @sebelga