-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] API Integration tests: adds test for Data Frame Analytics evaluate endpoint #97856
[ML] API Integration tests: adds test for Data Frame Analytics evaluate endpoint #97856
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see these tests coming! 🎉
Just one nit and a suggestion.
eval: any; | ||
} | ||
|
||
const testJobConfigs: TestConfig[] = ['regression', 'classification'].map((jobType, idx) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: idx
isn't used, so could be removed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins, test this (necessary for Jenkins update) |
@elasticmachine merge upstream |
LGTM |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…te endpoint (elastic#97856) * wip: add api test for evaluate endpoint * Add api test for evaluate endpoint * add tests for view only and unauthorized user Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…te endpoint (elastic#97856) * wip: add api test for evaluate endpoint * Add api test for evaluate endpoint * add tests for view only and unauthorized user Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…te endpoint (elastic#97856) * wip: add api test for evaluate endpoint * Add api test for evaluate endpoint * add tests for view only and unauthorized user Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…te endpoint (elastic#97856) * wip: add api test for evaluate endpoint * Add api test for evaluate endpoint * add tests for view only and unauthorized user Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…te endpoint (#97856) (#98182) * wip: add api test for evaluate endpoint * Add api test for evaluate endpoint * add tests for view only and unauthorized user Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…te endpoint (#97856) (#98181) * wip: add api test for evaluate endpoint * Add api test for evaluate endpoint * add tests for view only and unauthorized user Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Part of meta issue #93205
Tests
evaluate
endpoint for regression and classification jobs.Checklist
Delete any items that are not applicable to this PR.