[deb/rpm] Generate os package specific kibana.yml #98213
Conversation
| const kibanaYML = readFileSync(configReadPath, { | ||
| encoding: 'utf-8', | ||
| }) | ||
| .replace(/#pid.file:.*/g, 'pid.file: /run/kibana/kibana.pid') |
There was a problem hiding this comment.
Let's verify these replacements were successful.
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
|
||
| let kibanaYML = readFileSync(configReadPath, { encoding: 'utf8' }); | ||
|
|
||
| [ |
There was a problem hiding this comment.
I'm iffy on this approach, but it does work. I looked into templating kibana.yml while preserving it's relatively static nature. Turning it into a template would remove validity of the yml, leading to more duplication.
Any thoughts here?
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jbudz
added
auto-backport
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
With the merge of elastic#98213, pid and log file settings were moved from command line options to kibana.yml. Package tests use a non-default kibana.yml and these settings were not applied. This updates our configuration to include these settings.
With the merge of #98213, pid and log file settings were moved from command line options to kibana.yml. Package tests use a non-default kibana.yml and these settings were not applied. This updates our configuration to include these settings.
With the merge of elastic#98213, pid and log file settings were moved from command line options to kibana.yml. Package tests use a non-default kibana.yml and these settings were not applied. This updates our configuration to include these settings.
…1073) With the merge of #98213, pid and log file settings were moved from command line options to kibana.yml. Package tests use a non-default kibana.yml and these settings were not applied. This updates our configuration to include these settings. Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
) (elastic#110734)" This reverts commit 5d0065f.
This adds a new build task to create OS Package specific kibana.yml's. Two configurations are written:
These configurations were originally passed in as CLI arguments, which takes precedence over yml configuration. This caused issued with deployments where these configurations needed to be modified, e.g. writing log files to an external file system.
Closes #91885