[Connectors][API] Updated connectors with isMissingSecrets flag

[YulNaumenko]

Resolves #94106

Current PR extended connectors server API with the new field isMissingSecrets, which is readonly from the API.
Update connectors APIs - create and update always set isMissingSecrets as true.
Add migration to add isMissingSecrets: true to all existing connectors.

For the exported connectors ndjson:

{
   "attributes":{
      "actionTypeId":".email",
      "config":{
         "from":"jo.naumenko@gmail.com",
         "hasAuth":true,
         "host":"lghjg",
         "port":7878,
         "secure":true,
         "service":null
      },
      "isMissingSecrets":true,
      "name":"test"
   },
   "coreMigrationVersion":"8.0.0",
   "id":"e8aa94e0-a6ef-11eb-bd58-6b2eae02c6ef",
   "migrationVersion":{
      "action":"7.14.0"
   },
   "references":[
      
   ],
   "type":"action",
   "updated_at":"2021-04-27T00:31:29.598Z",
   "version":"WzE4LDFd"
}{
   "attributes":{
      "actionTypeId":".server-log",
      "config":{
         
      },
      "isMissingSecrets":false,
      "name":"test"
   },
   "coreMigrationVersion":"8.0.0",
   "id":"ed02cb70-a6ef-11eb-bd58-6b2eae02c6ef",
   "migrationVersion":{
      "action":"7.14.0"
   },
   "references":[
      
   ],
   "type":"action",
   "updated_at":"2021-04-27T00:31:36.883Z",
   "version":"WzE5LDFd"
}{
   "exportedCount":2,
   "missingRefCount":0,
   "missingReferences":[
      
   ]
}

Export will be done in the separate issue

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

[mikecote]

@ymao1 I've added you as a reviewer to ensure this aligns with what you were thinking for import/export.

[ymao1]

I tried testing out the migration by running master and creating an action, then running this branch. I get this error:

Error: Unable to complete saved object migrations for the [.kibana] index. Error: [{"index":{"error":{"type":"strict_dynamic_mapping_exception","reason":"mapping set to strict, dynamic introduction of [isMissingSecrets] within [action] is not allowed"}}}]

I see the addition of the field within the actions mapping.json, so maybe I'm doing something wrong? 🤔

[mikecote]

I tried testing out the migration by running master and creating an action, then running this branch.

@ymao1 (just popping my head) This may be happening bacause the migrations got skipped. It may have detected you were on the same Kibana version as master. If true, to make migrations happen, you'd need to run a prior version (ex: 7.x) ES + Kibana and then upgrade both. If you're using snapshots, you'll also need to make it persist the Elasticsearch data by using something like yarn es snapshot --ssl -E path.data=/my/path/to/data. Feel free to reach out to me if a manual run-through is easier. It can get a bit complex.

[ymao1]

LGTM! Just a minor comment about formatting in the legacy API docs

[patrykkopycinski]

Threat hunting LGTM

[jonathan-buttner]

@XavierM Do we need to do a migration in the detection rules area like we had to do last time?

[gchaps]

LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 8a4da38
• Storybooks Preview
• Documentation Changes

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
actions	113	114	+1

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
action	5	6	+1

Unknown metric groups

API count

id	before	after	diff
actions	113	114	+1

History

• 💔 Build #122729 failed 7f11c3d
• 💚 Build #122709 succeeded d15d490
• 💔 Build #122744 failed 236221b
• 💚 Build #122577 succeeded defad11
• 💔 Build #122571 failed b950b18

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko