Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): moving @kbn/apm-config-loader into bazel #98323

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 26, 2021

One step forward on #69706

That PR moves the @kbn/apm-config-loader into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic mentioned this pull request Apr 26, 2021
23 tasks
@mistic mistic added auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0 labels Apr 26, 2021
@mistic mistic marked this pull request as ready for review April 26, 2021 16:28
@mistic mistic requested review from vigneshshanmugam and a team as code owners April 26, 2021 16:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from jbudz April 26, 2021 16:29
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic

This comment has been minimized.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 7c043dc into elastic:master Apr 27, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 98323

mistic added a commit to mistic/kibana that referenced this pull request Apr 27, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	docs/developer/getting-started/monorepo-packages.asciidoc
#	packages/BUILD.bazel
#	packages/kbn-apm-config-loader/package.json
mistic added a commit that referenced this pull request Apr 27, 2021
…98528)

* chore(NA): moving @kbn/apm-config-loader into bazel (#98323)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	docs/developer/getting-started/monorepo-packages.asciidoc
#	packages/BUILD.bazel
#	packages/kbn-apm-config-loader/package.json

* docs(NA): fix docs merge head
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants