Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/dev-utils into bazel #98496

Merged
merged 3 commits into from
Apr 28, 2021
Merged

chore(NA): moving @kbn/dev-utils into bazel #98496

merged 3 commits into from
Apr 28, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 27, 2021

One step forward on #69706

That PR moves the @kbn/dev-utils into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic mentioned this pull request Apr 27, 2021
Closed
23 tasks
@mistic mistic added auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0 labels Apr 27, 2021
@mistic mistic marked this pull request as ready for review April 27, 2021 17:27
@mistic mistic requested review from a team as code owners April 27, 2021 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from jbudz April 27, 2021 17:27
alisonelizabeth
alisonelizabeth approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI changes LGTM

jbudz
jbudz approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic mistic enabled auto-merge (squash) April 28, 2021 16:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Apr 28, 2021

@elastic/kibana-app-services as that changed only change a little part of a package.json from a package under your code owners and I need that change in in order to unblock me on other package migrations I'm going to go ahead with the merge. Let me know if you have any feedback regarding that PR.

@mistic mistic disabled auto-merge April 28, 2021 22:46
@mistic mistic merged commit f690c60 into elastic:master Apr 28, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 28, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/dev-utils into bazel (elastic#98496)
490f03e 
* chore(NA): moving @kbn/dev-utils into bazel

* docs(NA): updated generated plugin list
@kibanamachine kibanamachine mentioned this pull request Apr 28, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 29, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/dev-utils into bazel (#98496) (#98696)
b3fc91c 
* chore(NA): moving @kbn/dev-utils into bazel

* docs(NA): updated generated plugin list

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@jbudz jbudz jbudz approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mistic @elasticmachine @kibanamachine @pgayvallet @jbudz @alisonelizabeth