[Remote clusters] Migrate to new ES client #98747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
Team:Kibana Management
17 tasks
|
@elasticmachine merge upstream |
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
74 tasks
|
@elasticmachine merge upstream |
yuliacech
approved these changes
May 4, 2021
There was a problem hiding this comment.
Thanks a lot for migrating Remote Clusters, @jloleysens! Code changes LGTM and tested locally 👍
I'll merge and backport this as soon as CI is green again.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @yuliacech |
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 4, 2021
* migrate add cluster route and jest tests * migrated delete remote clusters route * migrated the get route * migrated the update route * added shared types file * reduce some test boilerplate * fix type issues introduced by new types from ES client Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yuliacech
added a commit
that referenced
this pull request
May 4, 2021
* migrate add cluster route and jest tests * migrated delete remote clusters route * migrated the get route * migrated the update route * added shared types file * reduce some test boilerplate * fix type issues introduced by new types from ES client Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #73973
Jest test refactor
Server side jest tests were refactored due to the different API exposed by the client. For each test file the steps taken were:
addRemoteClustersTestand associated interfaceTestOptionsbeforeEachThe intention was to make the tests more standardised with the patterns in our other plugins and to not introduce too much additional "test creator" functionality since this can make the tests harder to maintain.
How to test
./.es/8.0.0/bin/elasticsearch -E cluster.name="elasticsearch" -E http.port=9222 -E node.name=node3 -E path.data=/tmp/data -E discovery.type=single-nodelocalhost:9301as the seed host for the remote cluster, this should be the default publish port for the second node