[Security Solution][Timeline] - Update cypress tests #99097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds using cypress chainables within tests
yctercero
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: cc @yctercero |
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
May 3, 2021
…lastic#99097) ###Summary Removes some anti-patterns I introduced in my last PR and makes use of Cypress' chainable pattern that will hopefully help with the flakiness.
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
May 3, 2021
…lastic#99097) ###Summary Removes some anti-patterns I introduced in my last PR and makes use of Cypress' chainable pattern that will hopefully help with the flakiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes some anti-patterns I introduced in my last PR and makes use of Cypress' chainable pattern that will hopefully help with the flakiness.
This was an interesting read to learn a bit more about some methods to use and some patterns that had already started being used within the detections cypress tests:
https://glebbahmutov.com/blog/cypress-should-callback/
Checklist