Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftr/esArchiver] disable geo_shape field of maps saved objects in archives #99119

Merged
merged 6 commits into from
May 4, 2021
Merged

[ftr/esArchiver] disable geo_shape field of maps saved objects in archives #99119

merged 6 commits into from
May 4, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 3, 2021 •
edited
Loading

Closes #98984

Several esArchives of the .kibana index include mappings for the now-removed bounds field of maps saved objects which includes now removed parameter "tree" and/or "strategy". Since these parameters were removed in ES master with elastic/elasticsearch#70850 we need to disable our usage of them, and in master we're currently setting the property in the mapping to

"bounds" : {
  "dynamic": false,
  "properties": {}
},

so I'm manually updating the mappings.json files to use the now disabled version of the "bounds" property.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 3, 2021
@spalger
Copy link
Contributor Author

spalger commented May 3, 2021

Successful build against unverified snapshot: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/123987/

@spalger spalger marked this pull request as ready for review May 4, 2021 01:07
@spalger spalger requested review from a team as code owners May 4, 2021 01:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

azasypkin
azasypkin approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in ESO test mappings LGTM

thomasneirynck
thomasneirynck approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review. thx for addressing @spalger

@spalger
Copy link
Contributor Author

spalger commented May 4, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 9e2e8b9 into elastic:master May 4, 2021
@spalger spalger deleted the fix/es-master-compat-geo_shape branch May 4, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[8.0] Failing ES Promotion: Various failures with mapper_parsing_exception
6 participants
@spalger @elasticmachine @kibanamachine @azasypkin @thomasneirynck @jbudz