Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Fixed parsing error in shard size query #99159

Merged
merged 1 commit into from
May 5, 2021
Merged

[Monitoring] Fixed parsing error in shard size query #99159

merged 1 commit into from
May 5, 2021

Conversation

igoristic
Copy link
Contributor

This PR addresses a regression caused by: #96177, since top level aggregations can't be defined without a filter (or a field):

[error][alerting][alerting][plugins][plugins] Executing Alert "95b82100-ac9c-11eb-90c0-bd5e5a7db140" has resulted in Error: parsing_exception, caused by: ""

@igoristic igoristic added bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v7.12.2 labels May 4, 2021
@igoristic igoristic added this to the Stack Monitoring UI 7.13 milestone May 4, 2021
@igoristic igoristic requested a review from a team May 4, 2021 06:39
@igoristic igoristic self-assigned this May 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@igoristic igoristic mentioned this pull request May 4, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @igoristic

@simianhacker simianhacker self-requested a review May 5, 2021 16:19
simianhacker
simianhacker approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested this with an extremely low value and it successfully fires as expected.

FYI... I originally tested this with Elastic Agent and it wouldn't fire because the backing indices for Agent are prefixed with .ds-*. I think this will become a problem in the future so I filled an issue: #99396

@igoristic igoristic merged commit b46a90e into elastic:master May 5, 2021
@igoristic igoristic deleted the fix_parsing_error branch May 5, 2021 21:29
This was referenced May 5, 2021
Merged
Merged
igoristic added a commit to igoristic/kibana that referenced this pull request May 5, 2021
@igoristic
Fixed aggs parsing error (elastic#99159)
6305410
@igoristic igoristic mentioned this pull request May 5, 2021
Merged
igoristic added a commit to igoristic/kibana that referenced this pull request May 5, 2021
@igoristic
Fixed aggs parsing error (elastic#99159)
1a41d7c 
# Conflicts:
#	x-pack/plugins/monitoring/server/lib/alerts/fetch_index_shard_size.ts
igoristic added a commit that referenced this pull request May 5, 2021
@igoristic
Fixed aggs parsing error (#99159) (#99420)
31d2d05
igoristic added a commit that referenced this pull request May 6, 2021
@igoristic
Fixed aggs parsing error (#99159) (#99422)
99a92d4 
# Conflicts:
#	x-pack/plugins/monitoring/server/lib/alerts/fetch_index_shard_size.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@ymao1 ymao1 mentioned this pull request May 11, 2021
Closed
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

igoristic added a commit that referenced this pull request May 12, 2021
@igoristic @kibanamachine
Fixed aggs parsing error (#99159) (#99416)
64ba8cc 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees

@igoristic igoristic

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team v7.12.2 v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
Stack Monitoring UI 7.13
Development

Successfully merging this pull request may close these issues.
4 participants
@igoristic @elasticmachine @kibanamachine @simianhacker