Fixed alerting health check behavior when alerting cannot find its health task in Task Manager. #99564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alth task in Task Manager.
YulNaumenko
added
Feature:Alerting
Team:ResponseOps
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
May 10, 2021
…alth task in Task Manager. (elastic#99564) * Fixed alerting health check behavior when alerting cannot find its health task in Task Manager. * fixed test * added unit tests
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
May 10, 2021
…alth task in Task Manager. (elastic#99564) * Fixed alerting health check behavior when alerting cannot find its health task in Task Manager. * fixed test * added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #98796
Current PR provides the next changes in the logic for the retrieving alerting framework health:
"_id" : "task:Alerting-alerting_health_check",does not exists we are scheduling the new task for the health checks and returns the status by calling the alerting savedObjects internal repository.Tested on the initial PR with reverting the change of the order here: https://github.com/elastic/kibana/pull/94968/files#diff-10bb6773064a1e6d04d4b1b5d5ad3954d8cfeb814b24d3c4db449c65528e1f0aR17 to reproduce the failing tests.