-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Address copy feedback #99632
Changes from all commits
41fa8b2
6490fbe
4396fdb
624fbbf
0c8e074
15cd468
62f75ca
b212a10
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,15 +13,9 @@ import { i18n } from '@kbn/i18n'; | |
import { LevelFilterOption } from '../../types'; | ||
|
||
const LocalizedOptions: { [option: string]: string } = { | ||
warning: i18n.translate( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not being used anymore |
||
'xpack.upgradeAssistant.checkupTab.controls.filterBar.warningButtonLabel', | ||
{ | ||
defaultMessage: 'warning', | ||
} | ||
), | ||
critical: i18n.translate( | ||
'xpack.upgradeAssistant.checkupTab.controls.filterBar.criticalButtonLabel', | ||
{ defaultMessage: 'critical' } | ||
{ defaultMessage: 'Critical' } | ||
), | ||
}; | ||
interface DeprecationLevelProps { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debadair since you suggested capitalizing
Critical
andWarning
, it seemed like we should also capitalize theBy issue
andBy index
filters on the ES deprecations page. Let me know if you disagree.