-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate joi
to 17.4.0
and adapt the codebase
#99899
Merged
pgayvallet
merged 32 commits into
elastic:master
from
pgayvallet:kbn-xxx-joi-migration-of-pain
May 20, 2021
Merged
Changes from 28 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
eefd427
bump joi to 17.4.0, start adapting stuff
pgayvallet a148a25
remove custom validation rule, adapt instead
pgayvallet f7591b2
fix error handling
pgayvallet 6c86026
fix error handling again
pgayvallet e23bcb0
fix strings type & validation
pgayvallet a8789e4
fix buffers and arrays
pgayvallet 1c454eb
fix bytes
pgayvallet f4578fa
fix bytes_size type
pgayvallet 5eab450
update conditional_type error messages in tests
pgayvallet 831649f
fix duration and map types
pgayvallet e76029d
first attempt to fix union type error messages
pgayvallet a6fd0e6
revert conditional type assertions back to master state
pgayvallet 83d41ab
fix object type
pgayvallet 69007a3
fix record type
pgayvallet 56eb879
fix stream types
pgayvallet cbf105e
rename test files to match sources
pgayvallet c238519
fix union type tests
pgayvallet 1783023
temporary adapt feature/home usages of Joi
pgayvallet f344583
fix lint
pgayvallet acf5073
adapt test assertion
pgayvallet 3513b24
fix http config schema validation
pgayvallet 73bd9f6
fix @kbn/test Config class
pgayvallet 3aa3b71
fix config again
pgayvallet d3617ed
Merge remote-tracking branch 'upstream/master' into kbn-xxx-joi-migra…
pgayvallet 1dfe1b0
fix reporting schema tests
pgayvallet 76d5445
fix security solution schema
pgayvallet 344926d
adapt url tests
pgayvallet 0952a6d
remove useless comment
pgayvallet 645f9fb
remove space
pgayvallet d1c61fe
typo
pgayvallet d0ff45d
Merge remote-tracking branch 'upstream/master' into kbn-xxx-joi-migra…
pgayvallet c69cbf1
review comments
pgayvallet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪