Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [TSVB] Filter by clicking on the timeseries chart (#97426) #99927

Merged
merged 1 commit into from
May 12, 2021

Conversation

stratoula
Copy link
Contributor

Backports the following commits to 7.x:

* WIP TSVB filter by click

* Disable filter click when showBar is set to false

* Exclude metric columns as they are not filtered

* Allow filters group by filter click event

* Fix CI and unit tests

* Add some comments

* Move to separate function for easier testing

* Add more unit tests

* Add a functional test

* Improve types

* Fix bug with group by filters and user applies custom labels

* fix time filter bug

* Address PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@stratoula stratoula enabled auto-merge (squash) May 12, 2021 14:02
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 503 504 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.7MB 1.7MB +2.9KB
visualizations 101.1KB 101.2KB +92.0B
total +3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimeseries 27.4KB 27.5KB +82.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 7571a10 into elastic:7.x May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants