Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Agent to remove the need to passing self to pipeline actions #10406

Open
1 of 2 tasks
colinsurprenant opened this issue Feb 6, 2019 · 3 comments
Open
1 of 2 tasks

refactor Agent to remove the need to passing self to pipeline actions #10406

colinsurprenant opened this issue Feb 6, 2019 · 3 comments
Labels
code cleanup

Comments

@colinsurprenant
Copy link
Contributor

colinsurprenant commented Feb 6, 2019 •
edited
Loading

This is a followup of issue #10346 review comment #10346 (comment)

The Agent object is currently passed into the different PipelineAction objects and is used for 2 purposes I believe:

I think we could refactor both to get rid of the requirement of passing the whole agent.
@colinsurprenant
Copy link
Contributor Author

Config thread safety fixed by @yaauie in #10415

@colinsurprenant colinsurprenant mentioned this issue Feb 12, 2019
Merged
@colinsurprenant
Copy link
Contributor Author

Created #10431 to remove Agent#exclusive

@colinsurprenant colinsurprenant mentioned this issue Feb 22, 2019
Closed
@colinsurprenant
Copy link
Contributor Author

Created #10488 to clean unused agent from ExecutionContext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinsurprenant