Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast/lir: simplify concurrent use of AST, which is globally stateful #10415

Closed
wants to merge 1 commit into from

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Feb 7, 2019

This was originally submitted by me as a patch in a comment on #10346, which I noticed continued an ongoing effort to juggle exclusive access to AST, which is stateful at the Module-level.

This PR obviates the need for, but does not actually deal with the removal of that complexity.

@colinsurprenant
Copy link
Contributor

Great refactor @yaauie - LGTM.

@colinsurprenant colinsurprenant self-requested a review February 8, 2019 20:28
@elasticsearch-bot
Copy link

Ry Biesemeyer merged this into the following branches!

Branch Commits
master b605161
7.0 13b84a1
7.x cfeaa54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants