ast/lir: simplify concurrent use of AST, which is globally stateful #10415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
force-pushed
the
concurrent-ast
branch
from
121fbbf to
931b8b2
Compare
|
Great refactor @yaauie - LGTM. |
colinsurprenant
approved these changes
Feb 8, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 9, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 9, 2019
This was referenced Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally submitted by me as a patch in a comment on #10346, which I noticed continued an ongoing effort to juggle exclusive access to AST, which is stateful at the
Module-level.This PR obviates the need for, but does not actually deal with the removal of that complexity.