properly set thread name in thread context #10269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guyboertje recently ran through me a bug he discovered in the workers thread naming which was introduced in #9973. I decided to submit this PR because I'd like to get this fix in before I go ahead and rebase and make progress with #9991.
The problem is that the call to
Util.set_thread_name
was made outside the newly created thread context and theUtil.set_thread_name
method set the passed name to the current thread context.The problem is that none of the worker threads were given a name and the pipeline thread name was set to the last worker thread name.
This problem was present on both Ruby and Java pipelines and for both cases using the hot thread API to gather the thread names this is the before/after:
Before
Note the single
[main]>worker7
thread (which is in fact thepipeline-manager
thread) and the manyRuby-0-Thread-X
threads:After
Note all the proper
[main]>workerX
threads and the[main]-pipeline-manager
thread: