Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java dependencies #10340

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

danhermann
Copy link
Contributor

Updates the following Java dependencies:

  • snakeyaml: 1.17 -> 1.23
  • log4j: 2.9.1 -> 2.11.1
  • jackson: 2.9.5 -> 2.9.8
  • janino: 3.0.8 -> 3.0.11
  • javassist: 3.22.0-GA -> 3.24.0-GA
  • json-unit: 1.9.0 -> 2.3.0
  • assertj-core: 3.8.0 -> 3.11.1

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danhermann
Copy link
Contributor Author

Thanks, @robbavey!

@danhermann danhermann merged commit e6d59de into elastic:master Jan 18, 2019
@danhermann danhermann deleted the update_java_dependencies branch January 18, 2019 14:16
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nitpick that javassist as new patch release

@@ -139,11 +139,11 @@ dependencies {
compile('com.google.googlejavaformat:google-java-format:1.1') {
exclude group: 'com.google.guava', module: 'guava'
}
compile 'org.javassist:javassist:3.22.0-GA'
compile 'org.javassist:javassist:3.24.0-GA'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's 3.24.1-GA already btw

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol should have refreshed the page before responding 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants