Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the ES endpoint to asks license #11297

Closed
wants to merge 1 commit into from
Closed

Fixes the ES endpoint to asks license #11297

wants to merge 1 commit into from

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Nov 11, 2019

In ES version 8 the end point for license check changed from _xpack/license to _license

@elasticsearch-bot elasticsearch-bot self-assigned this Nov 11, 2019
jsvd
jsvd reviewed Nov 11, 2019
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use this PR to remove any paths that include '_xpack' and not just this one call?

there are other mentions of "/_xpack" in the code that need to be changed for 8.0.0-alpha1, like security documentation (e.g. _xpack/monitoring), or x-pack tests.

@jsvd
Copy link
Member

jsvd commented Nov 11, 2019

to add more context, this is due to the following PR in elasticsearch: https://github.com/elastic/elasticsearch/pull/48170/files#diff-39909a6f11854c30867a6b59644d2501R57

jsvd
jsvd approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for the commit message let's write something like "Drop _xpack namespace for ES security and license endpoints"

@andsel andsel force-pushed the fix/update_es_license_path branch from 6f0e92d to 2f66f35 Compare November 12, 2019 16:14
@elasticsearch-bot
Copy link

Andrea Selva merged this into the following branches!

Branch Commits
master aad25d9

@andsel andsel mentioned this pull request Nov 12, 2019
Closed
@jsvd jsvd added the v8.0.0 label Nov 13, 2019
@jsvd jsvd mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

Assignees
No one assigned
Labels
v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andsel @jsvd @elasticsearch-bot