Add redis output congestion_attempts #1148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think there should be option NOT to try different server on congestion as it is highly dependant on the infra setup, and in some cases trying different redis would be wrong thing to do.So I'd change the PR so that :congestion_attempts set to zero would mean to never migrate to different redis server during congestion. |
Author
|
I agree with the option to disable the congestion attempt feature. Now defaults to 0, which will disable the feature. |
|
Can one of the admins verify this patch? |
|
👍 Looking forward to to this being merged |
jordansissel
force-pushed
the
master
branch
from
f86287d to
a536eef
Compare
|
@robbydyer -- Any chance you could sign this CLA to get this merged :) |
Author
|
CLA signed. |
|
YTMND |
Member
|
Thanks for this PR! Migrated it to the plugin repo, since we've separated plugins from the core logstash-plugins/logstash-output-redis#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a list of redis hosts is given to the redis output and the congestion_threshold is hit, it should try sending the output to a different host in the list after a certain number of attempts. This is useful in cases where the consumers of the redis lists are down. As it is now, logstash will just keep attempting to send output to the same host, rather than attempting another one in its list.