Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Added section for monitoring.cluster_uuid #11535

Closed
wants to merge 4 commits into from

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Jan 24, 2020

monitoring.cluster_uuid is the Elasticsearch cluster UUID to bind to Logstash metrics. This should go also on 7.7 version

`monitoring.cluster_uuid` is the Elasticsearch cluster UUID to bind to Logstash metrics
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting changes are needed to get docs-ci to pass. Let's discuss if my comments aren't clear. Thanks for your work on this!

docs/static/monitoring/monitoring-mb.asciidoc Outdated Show resolved Hide resolved
docs/static/monitoring/monitoring-mb.asciidoc Outdated Show resolved Hide resolved
docs/static/monitoring/monitoring-mb.asciidoc Outdated Show resolved Hide resolved
----------------------------------

--

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments:

  • Is this an optional or required step? (If optional, let's notate that in the heading.)
  • Is this a new step between our current steps 1 and 2? If so, it should be listed as a step around line 18. If it is a sub-section under "Disable default collection" then the heading needs one more = to format it correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karenzone thanks for watching. It's an optional step between 1 and 2. This is needed because on Kibana we want to group together the stats of LS and ES related to the same cluster. Metricbeat should bring this field and forward to ES

andsel and others added 3 commits January 24, 2020 16:53
Co-Authored-By: Karen Metts <35154725+karenzone@users.noreply.github.com>
Co-Authored-By: Karen Metts <35154725+karenzone@users.noreply.github.com>
Co-Authored-By: Karen Metts <35154725+karenzone@users.noreply.github.com>
@andsel andsel changed the title Added section for monitoring.cluster_uuid [Doc] Added section for monitoring.cluster_uuid Jan 24, 2020
@karenzone
Copy link
Contributor

Awesome! Elasticsearch-ci/docs passed. Preview is here: http://logstash_11535.docs-preview.app.elstc.co/guide/en/logstash/current/monitoring-with-metricbeat.html

@andsel
Copy link
Contributor Author

andsel commented Jan 24, 2020

Closed because this is against 7.5 while should be for master branch and 7.7 version. Created #11538

@andsel andsel closed this Jan 24, 2020
@andsel andsel deleted the feature/add_cluster_uuid_definition branch January 24, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants