Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments to send monitoring data directly to ES #11541
Adjustments to send monitoring data directly to ES #11541
Changes from all commits
61d1634
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to consider removing the
xpack
settings here, and just have themonitoring
settings. We should also make a note to surface this in release notes and blogs for the7.7.0
releaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens in the case of configuration reloads? Will new
cluster_uuids
be picked up?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case direct shipping is enabled and a user change the ES output configuration in one of the pipelines those new
cluster_uuids
aren't brought up by the monitoring pipeline because the monitoring pipeline is not restarted.Actually when the agent
converge_state_and_update
it reloads the changed pipelines andupdate_metrics
but doesn't reload also the monitoring pipeline, should we scatter a refresh of that pipeline also?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However this behaveior is almost aligned to what it's done for not direct shipping, because in that case the ES to ship data is loaded from
logstash.yml
and that ES is responsible to enrich the data withcluster_uuid
, so that configuration to be changed force the user to restart LogstashThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm ok with this, and we can always follow up if this becomes an issue.
Its slightly different from the non-direct shipping case, as the
logstash.yml
changes would be a change to the location of the monitoring data, whereas the changes drawn from reloaded plugins would be a change to where that data is shown in the monitoring cluster.