Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed timeformat that introduced flaky tests depending on time #11652

Closed

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Mar 4, 2020

With PR #11541 we formated the date_time field to be pushed to ES with bad format, used %k instead of %H, so in some cases (when hour < 10AM) generating hour with space instead of padding 0, for example...T 8:... instead of ..T08:...

@elasticsearch-bot elasticsearch-bot self-assigned this Mar 4, 2020
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, added a minor suggestion to fix an indentation hiccup

@elasticsearch-bot
Copy link

Andrea Selva merged this into the following branches!

Branch Commits
master fc0ced5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants