Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]Restructure monitoring to support new and legacy internal collectors for 7.x #11787

Closed
wants to merge 1 commit into from

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Apr 14, 2020

Backports #11714 to 7.x

[Doc]Restructure monitoring docs to support new and legacy internal collectors #11714

  • [Doc] added description of xpack.monitoring.collection.write_direct.enabled setting
  • Added page to mark as deprecated the legacy internal collector and fixed all the xpack.monitoring.* references
  • Included legacy collector file into monitoring overview
  • Restructure monitoring docs
  • Incorporate review comments
    Co-authored-by: andsel selva.andre@gmail.com

…ollectors (elastic#11714)

* [Doc] added description of xpack.monitoring.collection.write_direct.enabled setting

* Added page to mark as deprecated the legacy internal collector and fixed all the `xpack.monitoring.*` references

* Included legacy collector file into monitoring overview

* Restructure monitoring docs

* Incorporate review comments

Co-authored-by: andsel <selva.andre@gmail.com>
@karenzone
Copy link
Contributor Author

@elasticmachine, run elasticsearch-ci/docs

@elasticsearch-bot
Copy link

Karen Metts merged this into the following branches!

Branch Commits
7.7 1d78fad
7.x dfe5cc5

elasticsearch-bot pushed a commit that referenced this pull request Apr 14, 2020
…tors (#11714)

* [Doc] added description of xpack.monitoring.collection.write_direct.enabled setting

* Added page to mark as deprecated the legacy internal collector and fixed all the `xpack.monitoring.*` references

* Included legacy collector file into monitoring overview

* Restructure monitoring docs

* Incorporate review comments

Co-authored-by: andsel <selva.andre@gmail.com>

Fixes #11787
elasticsearch-bot pushed a commit that referenced this pull request Apr 14, 2020
…tors (#11714)

* [Doc] added description of xpack.monitoring.collection.write_direct.enabled setting

* Added page to mark as deprecated the legacy internal collector and fixed all the `xpack.monitoring.*` references

* Included legacy collector file into monitoring overview

* Restructure monitoring docs

* Incorporate review comments

Co-authored-by: andsel <selva.andre@gmail.com>

Fixes #11787
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karenzone do you still want to merge to 7.16?
It is a clean backport, once the conflicts are solved, I can approve it.

Copy link
Contributor Author

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jarvis merged these changes into 7.7 and 7.x, as indicated here: #11787 (comment). So that means that these changes are present in every branch from 7.7 and beyond. And yes, I verified this statement by checking github. A sample for reference: https://github.com/elastic/logstash/blame/7.16/docs/static/monitoring/collectors-legacy.asciidoc

Jarvis had a weird quirk whereby it wouldn't close a PR that was based out of any branch other than main. All that to say, we can safely close this PR as it has been merged. I will do that now.

Thanks for circling back around on this, @kaisecheng ❤️

@karenzone
Copy link
Contributor Author

Closing per this comment: #11787 (review).

@karenzone karenzone closed this Jan 19, 2022
@karenzone karenzone deleted the monitoring-take3-7.x branch January 19, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants