Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update timezone grok-patterns #1321

Closed
wants to merge 1 commit into from
Closed

Update timezone grok-patterns #1321

wants to merge 1 commit into from

Conversation

dgouyette
Copy link

colinsurprenant
colinsurprenant reviewed May 10, 2014
View reviewed changes
patterns/grok-patterns
@@ -68,7 +68,7 @@ ISO8601_SECOND (?:%{SECOND}|60)
TIMESTAMP_ISO8601 %{YEAR}-%{MONTHNUM}-%{MONTHDAY}[T ]%{HOUR}:?%{MINUTE}(?::?%{SECOND})?%{ISO8601_TIMEZONE}?
DATE %{DATE_US}|%{DATE_EU}
DATESTAMP %{DATE}[- ]%{TIME}
TZ (?:[PMCE][SD]T|UTC)
TZ (?:[PMCE][SD]T|UTC|CEST)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while in central zone, shouldn't we also add CET?

@colinsurprenant
Copy link
Contributor

Thanks for the contribution. See comment inline. Also, it would be really great if you could add specs for this in spec/filters/grok.rb. Let us know if you need help with this.

@colinsurprenant colinsurprenant added this to the v1.4.2 milestone May 10, 2014
@dgouyette
Copy link
Author

If you take a look to the following url, a lot of timezone are missing.
http://www.java2s.com/Code/Java/Development-Class/DisplayAvailableTimeZones.htm
Can i add use ActiveSupport::TimeZone to make it work for all timezones ?
I will also provide specs for it

@colinsurprenant colinsurprenant changed the title Update grok-patterns Update timezine grok-patterns May 10, 2014
@colinsurprenant colinsurprenant changed the title Update timezine grok-patterns Update timezone grok-patterns May 10, 2014
@colinsurprenant
Copy link
Contributor

How would you suggest using ActiveSupport for this?

dgouyette added a commit to dgouyette/logstash that referenced this pull request May 15, 2014
@dgouyette
#elastic#1321 add CEST and CET timezone to TZ
cae0871
@dgouyette
Copy link
Author

I made this pull request #1378
Is it ok for you ?

I will make an example with active support later, i don't know logstash enougth

@colinsurprenant
Copy link
Contributor

Ok, since you created a new PR #1378 I will close this one as duplicate.

@colinsurprenant colinsurprenant removed this from the v1.4.2 milestone May 15, 2014
@colinsurprenant colinsurprenant mentioned this pull request May 15, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgouyette @colinsurprenant