Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin manager test that fail to fetch dependency #13270

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Oct 4, 2021

Release notes

[rn:skip]

What does this PR do?

tests from #13218 are flickering
remove the untouchable source that fail to provide gem dependency

Why is it important/What is the impact to the user?

Gem.sources is a static setting across the project. As the new test cases fetch the dependencies from internet, a fake/ mock sources fail to provide the information, thus fail the tests.

The jenkins tests failed [7.x] [7.15]

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kaisecheng kaisecheng changed the title Fix plugin manager test that fail to fetch dependency [WIP] Fix plugin manager test that fail to fetch dependency Oct 4, 2021
@kaisecheng kaisecheng changed the title [WIP] Fix plugin manager test that fail to fetch dependency Fix plugin manager test that fail to fetch dependency Oct 4, 2021
Copy link
Contributor

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

the CI failure looks intermittent (and is not related to the changes here)

rspec ./specs/secret_store_spec.rb:58 # Test that Logstash expands secret store variables from config

@kaisecheng kaisecheng merged commit 50834d0 into elastic:master Oct 5, 2021
kaisecheng added a commit to kaisecheng/logstash that referenced this pull request Oct 5, 2021
kaisecheng added a commit to kaisecheng/logstash that referenced this pull request Oct 5, 2021
kaisecheng added a commit that referenced this pull request Oct 5, 2021
kaisecheng added a commit that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants