Update docker.asciidoc #13810
Open
Update docker.asciidoc #13810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the base image name and link. Logstash is now using Ubuntu instead of Centos.
|
@karenzone Can you give this final approval, content looks good |
karenzone
reviewed
Mar 2, 2022
| @@ -1,7 +1,7 @@ | |||
| [[docker]] | |||
| === Running Logstash on Docker | |||
| Docker images for Logstash are available from the Elastic Docker | |||
| registry. The base image is https://hub.docker.com/_/centos/[centos:7]. | |||
| registry. The base image is https://hub.docker.com/_/ubuntu[ubuntu:20.04]. | |||
There was a problem hiding this comment.
Suggested change
| registry. The base image is https://hub.docker.com/_/ubuntu[ubuntu:20.04]. | |
| registry. The base image is https://hub.docker.com/_/ubuntu[ubuntu], currently `ubuntu:20.04`. |
There was a problem hiding this comment.
Thanks for this change, @Tibo669. I've suggested a minor tweak to make the link text more accurately reflect the link destination. This tweak would be more user friendly for people using screen readers.
|
Hi @Tibo669 , Is this something you want to pursue forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
Fix the base image name and link in the "Running Logstash on Docker" page.
Logstash is now using Ubuntu instead of Centos:
#13438
Updating the docs from: The base image is centos:7.
To: The base image is ubuntu:20.04.
Why is it important/What is the impact to the user?
The link and name of the base image should reflect the recent changes.
Checklist
Author's Checklist
How to test this PR locally
Related issues
#13438
Use cases
Screenshots
Logs