Add Bytes setting type #6022
Closed
Add Bytes setting type #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyograo
reviewed
Oct 11, 2016
| @@ -0,0 +1,380 @@ | |||
| # encoding: utf-8 | |||
There was a problem hiding this comment.
Done. Leftover from some git surgery that went nearly-wrong.
jordansissel
force-pushed
the
feature/bytes_setting
branch
2 times, most recently
from
36e914c to
dc0ab1d
Compare
jordansissel
force-pushed
the
feature/bytes_setting
branch
from
dec4fba to
162c5a9
Compare
|
Rebased on master. Waiting for Travis .... |
|
@jordansissel this is good to merge. Kafka test failures are unrelated to this PR. |
jsvd
reviewed
Oct 31, 2016
| @@ -1,5 +1,10 @@ | |||
| # encoding: utf-8 | |||
| require "logstash/util/loggable" | |||
| require "fileutils" | |||
| require "logstash/util/byte_value" | |||
There was a problem hiding this comment.
double the require, double the fun!
jordansissel
force-pushed
the
feature/bytes_setting
branch
from
162c5a9 to
8c60bb1
Compare
|
Test failed due to kafka, not this PR. |
|
Will merge once @colinsurprenant is done suffering through some git merge work. <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used with persistent queue and eventually can be used for other things.