[ML] Make logger test more robust to slow VMs #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-ASCII logging test could hang indefinitely if the VM it was running on stalled for 200ms before reconfiguring the logger to use the test pipe. This change makes it more robust. A stall of up to 5 seconds is now tolerated, but with checks every 50ms to avoid slowing the test down.
Author
|
This is an example of a CI failure due to the problem: It's particularly annoying because the Jenkins job times out after 2 hours, so the CI machine is blocked from running anything else during this time. |
droberts195
pushed a commit
that referenced
this pull request
May 23, 2018
The non-ASCII logging test could hang indefinitely if the VM it was running on stalled for 200ms before reconfiguring the logger to use the test pipe. This change makes it more robust. A stall of up to 5 seconds is now tolerated, but with checks every 50ms to avoid slowing the test down.
droberts195
pushed a commit
that referenced
this pull request
May 23, 2018
The non-ASCII logging test could hang indefinitely if the VM it was running on stalled for 200ms before reconfiguring the logger to use the test pipe. This change makes it more robust. A stall of up to 5 seconds is now tolerated, but with checks every 50ms to avoid slowing the test down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-ASCII logging test could hang indefinitely if the VM it
was running on stalled for 200ms before reconfiguring the logger
to use the test pipe.
This change makes it more robust. A stall of up to 5 seconds is
now tolerated, but with checks every 50ms to avoid slowing the
test down.