[ML] Correct the way internal linkage of constants is achieved #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. There's no need for constants declared in unnamed namespaces to be declared static - they already have internal linkage 2. Constants of type char* pointing to literals should be declared const char* const - declaring them const char* does not result in internal linkage because it allows them to be changed to point at something completely different!
davidkyle
reviewed
May 23, 2018
| #else | ||
| #ifdef __GNUC__ | ||
| // Tell g++ that it's reasonable that this variable isn't used | ||
| __attribute__((unused)) static const char* LINE_ENDING = "\n"; |
Author
There was a problem hiding this comment.
No, now this really is a constant with internal linkage it's not needed.
In fact, the warning from g++ was the canary in the mine warning that something was not right. Suppressing the warning was the wrong way to avoid it.
davidkyle
approved these changes
May 24, 2018
droberts195
pushed a commit
that referenced
this pull request
May 24, 2018
1. There's no need for constants declared in unnamed namespaces to be declared static - they already have internal linkage. 2. Constants of type char* pointing to literals should be declared const char* const - declaring them const char* does not result in internal linkage because it allows them to be changed to point at something completely different!
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Feb 21, 2019
Follow-on to elastic#102. Fixing more places where pointers intended to be immutable could be changed to a point at a different constant.
droberts195
pushed a commit
that referenced
this pull request
Feb 21, 2019
Follow-on to #102. Fixing more places where pointers intended to be immutable could be changed to a point at a different constant.
droberts195
pushed a commit
to droberts195/ml-cpp
that referenced
this pull request
Feb 21, 2019
Follow-on to elastic#102. Fixing more places where pointers intended to be immutable could be changed to a point at a different constant. Backport of elastic#409
droberts195
pushed a commit
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be declared
static- they already have internal linkage.char*pointing to literals should bedeclared
const char* const- declaring themconst char*doesnot result in internal linkage because it allows them to be
changed to point at something completely different!