Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Refactor tests that use CDataGatherer constructor #2845

Merged
merged 23 commits into from
Apr 8, 2025

Conversation

valeriy42
Copy link
Contributor

This is a refactoring PR. It cleans up and refactors some unit tests. No functional changes have been made.

It also fixes the linting issues from clang-tidy and SonarQube.

@valeriy42 valeriy42 requested a review from edsavage March 28, 2025 15:02
@valeriy42 valeriy42 self-assigned this Mar 28, 2025
@valeriy42 valeriy42 marked this pull request as draft March 28, 2025 15:24
@valeriy42 valeriy42 removed the request for review from edsavage March 28, 2025 15:24
@valeriy42 valeriy42 requested a review from edsavage April 3, 2025 13:58
@valeriy42 valeriy42 marked this pull request as ready for review April 3, 2025 13:58
Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of nits in the comments.

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
9.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

@valeriy42 valeriy42 merged commit c6334ab into elastic:main Apr 8, 2025
12 of 15 checks passed
@valeriy42 valeriy42 deleted the refactoring/data-gatherer branch April 8, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants