Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature Flag page with new FQDN setting #2817

Merged
merged 8 commits into from
Apr 6, 2023

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Mar 31, 2023

This updates the Standalone Elastic Agent section with a Feature flag page, including the new FQDN setting.

Note: Hold off on merging until elastic/elastic-agent#2218 is merged.

See: preview

Rel: #1641

@kilfoyle kilfoyle added the backport-8.7 Automated backport with mergify label Mar 31, 2023
@kilfoyle kilfoyle requested a review from ycombinator March 31, 2023 01:21
@kilfoyle kilfoyle requested a review from a team as a code owner March 31, 2023 01:21
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@ycombinator
Copy link
Contributor

@kilfoyle A couple of notes tangentially related to this PR:

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Apr 3, 2023

Thanks for the careful review @ycombinator!

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview LGTM. Thanks @kilfoyle for taking care of this!

kilfoyle and others added 2 commits April 3, 2023 16:10
…agent-standalone-features.asciidoc

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
@ycombinator
Copy link
Contributor

Note: Hold off on merging until elastic/elastic-agent#2218 is merged.

@kilfoyle elastic/elastic-agent#2218 has now been merged, so you can go ahead with merging this PR here. Thanks!

@kilfoyle kilfoyle merged commit 5a20c76 into elastic:main Apr 6, 2023
mergify bot pushed a commit that referenced this pull request Apr 6, 2023
* Add Feature Flag page with new FQDN setting

* Fix up host.name description

* Touchup

* Fix up the feature flag description

* Add FQDN prereqs

* touchup

* Update docs/en/ingest-management/elastic-agent/configuration/elastic-agent-standalone-features.asciidoc

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>

* Revert rephrasing of feature flag intro cd78011

---------

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
(cherry picked from commit 5a20c76)
kilfoyle added a commit that referenced this pull request Apr 6, 2023
* Add Feature Flag page with new FQDN setting

* Fix up host.name description

* Touchup

* Fix up the feature flag description

* Add FQDN prereqs

* touchup

* Update docs/en/ingest-management/elastic-agent/configuration/elastic-agent-standalone-features.asciidoc

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>

* Revert rephrasing of feature flag intro cd78011

---------

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
(cherry picked from commit 5a20c76)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
* Add Feature Flag page with new FQDN setting

* Fix up host.name description

* Touchup

* Fix up the feature flag description

* Add FQDN prereqs

* touchup

* Update docs/en/ingest-management/elastic-agent/configuration/elastic-agent-standalone-features.asciidoc

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>

* Revert rephrasing of feature flag intro cd78011

---------

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.7 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants