Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs after migrating from apm integration package to ES apm-data plugin in 8.15 #4239

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Sep 12, 2024

Description

Remove mentions of integration packages as apm-server moved away from it in 8.15

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@carsonip carsonip added the backport-8.15 Automated backport with mergify label Sep 12, 2024
Copy link
Contributor

mergify bot commented Sep 12, 2024

This pull request is now in conflict. Could you fix it @carsonip? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 8.15-apm-data upstream/8.15-apm-data
git merge upstream/main
git push upstream 8.15-apm-data

@bmorelli25 bmorelli25 added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@@ -65,6 +65,5 @@ If you prefer more guidance, see one of these tutorials:

* <<apm-filters-ingest-pipeline>> — Learn how to obfuscate passwords stored in the `http.request.body.original` field.
* <<apm-data-stream-rerouting>> — Learn how to reroute APM data to user-defined APM data streams.
* {fleet-guide}/data-streams-pipeline-tutorial.html[Transform data with custom ingest pipelines] — A basic Elastic integration tutorial where you learn how to add a custom field to incoming data.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a shame, as the tutorial is good, but some instructions do not apply to ES plugin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking next steps for that tutorial in #4314.

@carsonip carsonip marked this pull request as ready for review September 25, 2024 21:10
@carsonip carsonip requested a review from a team as a code owner September 25, 2024 21:10
@colleenmcginnis colleenmcginnis self-assigned this Sep 25, 2024
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question.

docs/en/observability/apm/data-streams.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
@colleenmcginnis colleenmcginnis enabled auto-merge (squash) October 1, 2024 13:42
@colleenmcginnis colleenmcginnis merged commit e495858 into elastic:main Oct 1, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
…ta plugin in 8.15 (#4239)

* Update doc to reflect migration from apm integration package to ES apm-data plugin

* Update docs/en/observability/apm/data-streams.asciidoc

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

* fix link syntax

---------

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
(cherry picked from commit e495858)
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
…ta plugin in 8.15 (#4239)

* Update doc to reflect migration from apm integration package to ES apm-data plugin

* Update docs/en/observability/apm/data-streams.asciidoc

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

* fix link syntax

---------

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
(cherry picked from commit e495858)
colleenmcginnis pushed a commit that referenced this pull request Oct 1, 2024
…ta plugin in 8.15 (#4239) (#4325)

* Update doc to reflect migration from apm integration package to ES apm-data plugin

* Update docs/en/observability/apm/data-streams.asciidoc

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

* fix link syntax

---------

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
(cherry picked from commit e495858)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
colleenmcginnis pushed a commit that referenced this pull request Oct 1, 2024
…ta plugin in 8.15 (#4239) (#4324)

* Update doc to reflect migration from apm integration package to ES apm-data plugin

* Update docs/en/observability/apm/data-streams.asciidoc

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>

* fix link syntax

---------

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
(cherry picked from commit e495858)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants