Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data stream docs to Fleet user guide #429

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Mar 5, 2021

Summary

This PR adds a general overview of data streams to the Fleet user guide. The content is not complete yet, but I don't have any additional time to devote to this in the current iteration. I'd like to publish this and circle back later with additional updates.

Unbeknownst to DeDe and I, it appears that the Elasticsearch documentation team has already put a lot of work into creating docs about data streams–as expected, some of this content is particularly useful for Fleet/Agent users. I'm not going to reinvent the wheel, so this PR borrows very heavily from the following sources:

Eventually, we may want to single-source some snippets of content from the ES repository.

Documentation preview

Click here to view a documentation preview

Related issues

For elastic/apm-server#4494.

@bmorelli25 bmorelli25 self-assigned this Mar 5, 2021
@apmmachine
Copy link
Contributor

A docs preview will be available soon:
- HTML diff
- Observability guide

@bmorelli25 bmorelli25 marked this pull request as ready for review March 11, 2021 00:19
@bmorelli25 bmorelli25 requested review from jalvz and a team March 11, 2021 00:19
@bmorelli25 bmorelli25 changed the title docs: data streams Add data stream docs to Fleet user guide Mar 11, 2021
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for doing this.

I have a few minor suggestions (mostly related to dashes...that's how you know the work is good...haha).

docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
As an added bonus, only relevant fields are shown in Discover.

* *More granular data control*: For example, filesystem, load, cpu, network, and process metrics are sent
to different indices–each potentially with its own rollover, retention, and security permissions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to different indices–each potentially with its own rollover, retention, and security permissions.
to different indices–-each potentially with its own rollover, retention, and security permissions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think -- gets converted into an em dash.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already an em dash :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to tell in the source file, but a little easier in the built version:
Screen Shot 2021-03-10 at 7 17 13 PM

docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
<type>-<dataset>-<namespace>
--

For example, if you've set up the Nginx integration with a namespace of `prod`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to format this differently to make it easier to scan. Maybe more white space? Honestly I think the line wraps in the middle of names are making it harder to follow the example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added additional white space and moved the examples to code blocks in 2ddd984.


TIP: If you're familiar with the concept of indices, you can think of each data stream as a separate index in {es}.
Under the hood though, things are a bit more complex.
All of the juicy details are available in {ref}/data-streams.html[{es} Data streams].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Knowing "juicy details" is way more intriguing than having to read some other docs. :->

bmorelli25 and others added 2 commits March 10, 2021 19:18
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@bmorelli25 bmorelli25 merged commit b7866bb into elastic:master Mar 11, 2021
@bmorelli25 bmorelli25 deleted the data-streams-docs branch March 11, 2021 19:27
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Mar 11, 2021
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Mar 11, 2021
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 added a commit that referenced this pull request Mar 11, 2021
Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 added a commit that referenced this pull request Mar 11, 2021
Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants