Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apm] Remove mentions of secret token in APM agent snippets in serverless docs #4503

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

colleenmcginnis
Copy link
Contributor

Description

Removes mentions of secret token in APM agent snippets in serverless docs.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4381

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@colleenmcginnis colleenmcginnis added backport-skip Skip notification from the automated backport with mergify needs-dev-review labels Nov 8, 2024
@colleenmcginnis colleenmcginnis self-assigned this Nov 8, 2024
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 8, 2024 14:18
Copy link
Contributor

github-actions bot commented Nov 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming these are all the instances where we mention tokens in the serverless docs, this LGTM!

@colleenmcginnis
Copy link
Contributor Author

Assuming these are all the instances where we mention tokens in the serverless docs, this LGTM!

I searched all serverless files for the word secret, reviewed all mentions, and updated the relevant mentions. ✅

@colleenmcginnis colleenmcginnis merged commit fa740a8 into elastic:main Nov 8, 2024
3 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-4381 branch November 8, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs-dev-review needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Remove secret-token from Serverless docs
3 participants