Set GenAi subtype for spans that have the gen_ai.system attribute

[xrmx]

Would like to avoid spans with unknown as type in kibana for genai libraries traced calls.

This has only been unit tested here, no clue on how to run this :)

Closes #111

[gregkalapos]

I think this makes sense.

Only reason this wasn't here is that this logic pre-dates popularity of genai.

Other side note: this code will be used within the OTel collector, but won't be used in APM Server/MIS, right?

I'd say that's fine, just flagging this, because until now, EDOT collector and APM Server/MIS behaved very similarly and here they'll diverge, which may be strange for users.

[codefromthecrypt]

and so it begins... 😛

[xrmx]

With the help of @gregkalapos I've setup things to test this but I'm not able to make this work locally and I get an unknown span.

These are the local changes I have in elastic-collector-components in order to test this:

diff --git a/distributions/elastic-components/manifest.yaml b/distributions/elastic-components/manifest.yaml
index b29bf5e..062405c 100644
--- a/distributions/elastic-components/manifest.yaml
+++ b/distributions/elastic-components/manifest.yaml
@@ -10,6 +10,7 @@ extensions:
   - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension v0.114.0
   - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/filestorage v0.114.0
   - gomod: go.opentelemetry.io/collector/extension/memorylimiterextension v0.114.0
+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/basicauthextension v0.114.0
 
 connectors:
   - gomod: github.com/elastic/opentelemetry-collector-components/connector/signaltometricsconnector v0.0.0
diff --git a/processor/elastictraceprocessor/go.mod b/processor/elastictraceprocessor/go.mod
index fc8bd49..29cd501 100644
--- a/processor/elastictraceprocessor/go.mod
+++ b/processor/elastictraceprocessor/go.mod
@@ -19,6 +19,8 @@ require (
        go.uber.org/zap v1.27.0
 )
 
+replace github.com/elastic/opentelemetry-lib => /home/rm/src/opentelemetry-lib
+
 require (
        github.com/cespare/xxhash/v2 v2.3.0 // indirect
        github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect

Do you see something I am missing?

[lahsivjar]

Do you see something I am missing?

If you are building ocb image then you will need to add replace directive in the ocb config (something like https://github.com/elastic/otel-apm-e2e-poc/blob/f45432edc2613f8997caed7c917ae71f5dec8d4d/ocb.yaml#L32) and then build the custom otel collector to do the testing.

[codefromthecrypt]

Curious about the timeline required to get this into the EDOT collector by default once merged? Is it feasible in Jan? (thinking about public demos and/or blogs)

[xrmx]

Do you see something I am missing?

If you are building ocb image then you will need to add replace directive in the ocb config (something like https://github.com/elastic/otel-apm-e2e-poc/blob/f45432edc2613f8997caed7c917ae71f5dec8d4d/ocb.yaml#L32) and then build the custom otel collector to do the testing.

Thanks but I get this error. Tried both building v0.114.0 in elastic-collector-components or v0.111.0 in otel-apm-e2e-poc.

Error: failed to update go.mod: go subcommand failed with args '[mod tidy -compat=1.22]': exit status 1, error message: go: finding module for package go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental
go: finding module for package go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental
go: go.opentelemetry.io/collector/cmd/builder imports
	go.opentelemetry.io/collector/receiver/otlpreceiver imports
	go.opentelemetry.io/collector/pdata/pprofile/pprofileotlp imports
	go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental: module go.opentelemetry.io/collector/pdata@latest found (v1.21.0), but does not contain package go.opentelemetry.io/collector/pdata/internal/data/protogen/collector/profiles/v1experimental
go: go.opentelemetry.io/collector/cmd/builder imports
	go.opentelemetry.io/collector/connector imports
	go.opentelemetry.io/collector/internal/fanoutconsumer imports
	go.opentelemetry.io/collector/pdata/pprofile imports
	go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental: module go.opentelemetry.io/collector/pdata@latest found (v1.21.0), but does not contain package go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental

[lahsivjar]

or v0.111.0 in otel-apm-e2e-poc

Hmm, might be something to do with version up, looks like the otel-e2e-poc has not been updated and otel lib is already using v0.115.0. Let me see if I can do a quick fix there.

[xrmx]

🎉

With https://github.com/elastic/otel-apm-e2e-poc/commit/21e7ef1849b6f45e8a0dea788746de6caee0e5ca and by remembering to not start the apm-server works fine. Thanks @lahsivjar and @gregkalapos for the help!