Mobile crash support #191
Merged
Mobile crash support #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package to get reused
bryce-b
reviewed
Jun 17, 2025
bryce-b
approved these changes
Jun 18, 2025
Contributor
Author
|
@felixbarny, @kruskall - Thank you for your first review. I've updated the PR to address your suggestions, it should be all good now. Please take another look. |
Member
|
I didn't do a full review but the thing I commented on is resolved, thanks! |
…lemetry-lib into mobile-crash-support
gregkalapos
approved these changes
Jul 1, 2025
Contributor
gregkalapos
left a comment
gregkalapos
left a comment
There was a problem hiding this comment.
The merge&resolving conflict looks ok to me. Sorry that my PR caused this.
kruskall
reviewed
Jul 1, 2025
elasticattr/attributes.go
Outdated
| ErrorType = "error.type" | ||
| ) | ||
|
|
||
| func GetTimestampUs(ts pcommon.Timestamp) int64 { |
Member
There was a problem hiding this comment.
this adds a dependency on collector/pdata to the elasticattr package. If downstream consumer are using this package (without any other package using collector) they will bring in the extra dependency.
Can we move this out ?
Contributor
Author
There was a problem hiding this comment.
Sure. I just made the changes.
kruskall
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/elastic/opentelemetry-dev/issues/831
Adds log crash event support by adding the following attributes to the logs with the
event.nameattribute or eventName field value set todevice.crash:The above attributes, along with the exception.* ones that come from the OTel conventions and should already be present on these kinds of logs, are what Kibana queries to properly display mobile crash events.
NOTE: Some of the logic needed for this to work was already present for traces, such as setting the
agent.nameresource attribute for example. To avoid duplicating code, I moved the common tools to a "common" dir.