enrichments: handle gen_ai.provider.name too #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
force-pushed
the
genai-new-semconv
branch
from
5396576 to
95077fb
Compare
Same enrichment as the previous gen_ai.system
xrmx
force-pushed
the
genai-new-semconv
branch
from
95077fb to
c28cb68
Compare
lahsivjar
approved these changes
Sep 8, 2025
Contributor
lahsivjar
left a comment
lahsivjar
left a comment
There was a problem hiding this comment.
LGTM! I don't have full context on gen AI instrumentation, and, while it seems like a very straightforward PR if you do require any technical review on the usage of the field please wait for other reviews.
Member
Author
I've merged it, the new attribute is just a rename of the current handled one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same enrichment as the previous gen_ai.system