-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate "base-field.yml" files #465
Comments
It might be a breaking change, so I will rollout changes in steps:
Are you ok with the scenario @ruflin ? |
@mtojek Steps look great. Like this from a consumer perspective things never break. One problem we have is that in old packages the fields don't exist, for example https://github.com/elastic/package-storage/tree/master/packages/cisco/0.1.0/dataset/asa/fields Now assuming we release 0.1.1 of this package, the old package will not validate in the package-registry. Should we update the 0.1.0 package too? It brings up the more general question: What do we do if the package registry adds more validation and an old package cannot be validated anymore? Not a big issue at the moment as we can still change things but probably worth discussing separately. Lets not block on this. |
Yes, I included also these in point 4.
We can document package format and version it. |
We have a package format version today: https://github.com/elastic/package-registry/blob/master/dev/packages/example/base/0.2.0/manifest.yml#L1 +1 on using it, but it would mean we keep legacy code in the registry for quite a while. I would say for now, lets fix the existing packages until we ship 7.9. |
All action items done. Resolving. |
All
base-field.yml
files must be provided by integrations.The package-storage will validate PRs to check if mentioned fields are present.
The text was updated successfully, but these errors were encountered: