Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-beats: create base fields #55

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 4, 2020

Issue: elastic/package-registry#465 (comment)

import-beats: create base-fields.yml files for each dataset

Testing:

I used haproxy integration for development, but didn't pull it in for clarity.

$ PACKAGES=haproxy mage ImportBeats
$ find packages/haproxy | grep base-fields
packages/haproxy/dataset/info/fields/base-fields.yml
packages/haproxy/dataset/stat/fields/base-fields.yml
packages/haproxy/dataset/log/fields/base-fields.yml
$ cat packages/haproxy/dataset/info/fields/base-fields.yml
- name: stream.type
  type: constant_keyword
  description: Stream type.
- name: stream.dataset
  type: constant_keyword
  description: Stream dataset.
- name: stream.namespace
  type: constant_keyword
  description: Stream namespace.
- name: '@timestamp'
  type: date
  description: Event timestamp.

@mtojek mtojek added the Team:Fleet Label for the Fleet team [elastic/fleet] label Jun 4, 2020
@mtojek mtojek requested a review from ruflin June 4, 2020 12:11
@mtojek mtojek self-assigned this Jun 4, 2020
@mtojek mtojek added Team:Integrations Label for the Integrations team and removed Team:Fleet Label for the Fleet team [elastic/fleet] labels Jun 4, 2020
@elasticmachine
Copy link

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #55 opened]

  • Start Time: 2020-06-04T12:11:53.225+0000

  • Duration: 4 min 46 sec

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

I'm torn if it should be the import script creating this or the script that releases the package. To be discussed later.

@mtojek mtojek merged commit 320395b into elastic:master Jun 4, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants