Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple paths in "publicDir" #505

Closed
mtojek opened this issue Jun 10, 2020 · 2 comments
Closed

Allow for multiple paths in "publicDir" #505

mtojek opened this issue Jun 10, 2020 · 2 comments

Comments

@mtojek
Copy link
Contributor

mtojek commented Jun 10, 2020

The aim of this task is to modify the Package Registry to allow for multiple different paths, similarly to the system PATH environment variable.

Justification:
When mounting the /registry/public directory, we need to prepare the source point:

  1. Fetch package-storage.
  2. Add the interesting ones (e.g. an integration a developer is currently working on)
  3. Build all packages.
  4. Mount the directory.

It would be much simpler, if the developer needs to prepare an additional custom public directory with built only single integration. No need for visiting package-storage if the target Docker image for registry already contains mandatory packages.

The registry would update version conflicts, the latter one in publicDir overrides previous revisions.

@ruflin
Copy link
Member

ruflin commented Jun 10, 2020

Assuming that we get completely rid of mage build and the registry can just read from directories directly, we could probably also get rid of the public name here as it is just packagePaths.

This was referenced Jun 10, 2020
@mtojek
Copy link
Contributor Author

mtojek commented Jun 16, 2020

I'm going with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants