Do not use generator #513
Merged
Do not use generator #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Jun 16, 2020
| @@ -88,6 +87,73 @@ func fetchPackageStorage() error { | |||
| packageStorageRevision) | |||
| } | |||
|
|
|||
| func buildPackages() error { | |||
There was a problem hiding this comment.
Looking forward for this one to also disappear!
There was a problem hiding this comment.
Yes, we have a plan for this one: #505
ruflin
approved these changes
Jun 16, 2020
This will result in a penalty action item to teach CI verifying this... |
💚 Build Succeeded
Expand to view the summary
Build stats
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #466 (comment)
Changes:
example)