Rename index-template directory to index_template

[ruflin]

As discussed in #552 (comment) for consistency reason we should use - or _ for all the directory names. The only exception at the moment is index-template. Instead it should be called index_template.

To support this change, not changes in the package-registry are needed but Kibana and packages need to be updated. The suggested path forward is:

• Update all packages with index_template but also keep index-template as a duplicate around Update base packages to use new paths package-storage#90
• Switch Kibana over to index_template, ilm_policy, component_template
• Remove all index-template directory in packages.

[ruflin]

Updating the base package, I realised there is also component-template and ilm-policy. I renamed both to component_template and ilm_policy. These also need to be updated on the Kibana side.

[ruflin]

@ycombinator @jonathan-buttner @mtojek Do you know of a place other then the base package where we use the above paths? Or one more path using -?

[jonathan-buttner]

@ycombinator @jonathan-buttner @mtojek Do you know of a place other then the base package where we use the above paths? Or one more path using -?

Thanks for the ping. I'm not aware of any others 👍

[ycombinator]

@ruflin What about the ingest-pipeline directories?

development/github/package-storage ‹master› » find packages -iname *-* -type d | awk -F\/ '{print $NF}' | sort | uniq -c
   3 component-template
   3 ilm-policy
   3 index-template
  65 ingest-pipeline

[ruflin]

@ycombinator Looks like I'm missed these :-(

[ruflin]

This now becomes a bit more complicated because of the ingest-pipelines as these exist in all packages. My thinking: Also add duplicates for the ingest-pipeline directory in all packages, get elastic/kibana#70320 in and then remove it?

[ruflin]

We now copied all directories with - in package-registry, package-storage and integrations repo to make it compatible with elastic/kibana#70320. The old directories can be removed when snapshot builds with elastic/kibana#70320 are available which is probably in the next 24h.

[ruflin]

Kibana updated, all assets removed from package-storage and package-registry and check built into registry now. Closing this issue.