-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listen with TLS if configured #746
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that we should expose some additional ENVs in the Dockerfile?
Added example to the documentation, and listening address is now configured with the environment variable, let me know if you would give more visibility to any other environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I guess that we have to make sure that these parameters work correctly with the Package Storage distribution.
They work, but I will also move the flags to environment variables there so everything can be customized this way in the docker images. |
Add flags to enable listening on TLS.
Fixes #711.