Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen with TLS if configured #746

Merged
merged 6 commits into from
Oct 14, 2021
Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 12, 2021

Add flags to enable listening on TLS.

Fixes #711.

@jsoriano jsoriano requested a review from mtojek October 12, 2021 09:53
@jsoriano jsoriano self-assigned this Oct 12, 2021
@elasticmachine
Copy link

elasticmachine commented Oct 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T10:09:03.157+0000

  • Duration: 5 min 16 sec

  • Commit: 1458e77

Test stats 🧪

Test Results
Failed 0
Passed 117
Skipped 0
Total 117

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that we should expose some additional ENVs in the Dockerfile?

@jsoriano jsoriano marked this pull request as ready for review October 13, 2021 16:09
@jsoriano
Copy link
Member Author

Do you think that we should expose some additional ENVs in the Dockerfile?

Added example to the documentation, and listening address is now configured with the environment variable, let me know if you would give more visibility to any other environment variable.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess that we have to make sure that these parameters work correctly with the Package Storage distribution.

CHANGELOG.md Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@jsoriano
Copy link
Member Author

jsoriano commented Oct 14, 2021

I guess that we have to make sure that these parameters work correctly with the Package Storage distribution.

They work, but I will also move the flags to environment variables there so everything can be customized this way in the docker images.

@jsoriano jsoriano requested a review from mtojek October 14, 2021 10:23
@jsoriano jsoriano merged commit 32109b3 into elastic:master Oct 14, 2021
@jsoriano jsoriano deleted the tls-support branch October 14, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TLS support
3 participants