Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery fields and tests for content packages #1220

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 10, 2024

Part of elastic/package-spec#351

Added tests related to content packages and the new discovery fields into the BasePackage manifest definition.

Tested also running locally Elastic Package Registry:

# use test package from package-spec repository
cd /path/to/package-spec/
cd test/packages/good_content
elastic-package build

docker build --build-arg GO_VERSION="$(cat .go-version)" --rm -t docker.elastic.co/package-registry/package-registry:test .
docker run --rm -it -p 8080:8080 -v /path/to/package-spec/build/packages:/packages/package-registry docker.elastic.co/package-registry/package-registry:main

curl "http://localhost:8080/search?type=content&all=true&prerelease=true"
curl "http://localhost:8080/search?type=content&package=good_content&prerelease=true"
curl "http://localhost:8080/search?package=good_content&prerelease=true"

@mrodm mrodm self-assigned this Sep 10, 2024
@mrodm mrodm marked this pull request as ready for review September 10, 2024 12:56
@mrodm mrodm requested a review from a team September 10, 2024 12:56
@mrodm mrodm changed the title Add tests for content packages Add discovery fields and tests for content packages Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 10, 2024

⚠️ The sha of the head commit of this PR conflicts with #1221. Mergify cannot evaluate rules on this PR. ⚠️

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm merged commit f90ac28 into elastic:main Sep 10, 2024
5 checks passed
@mrodm mrodm deleted the support-content-packages branch September 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants